search

lukehutch / serverx

A Vert.x-powered asynchronous multithreaded web server with simple annotation-based configuration of routes
MIT License
19 stars 1 forks source link

Compile issues w/ deprications in Vertx 4milestoneX #2

Open runnermann opened 4 years ago

runnermann commented 4 years ago

Hello, There are multiple deprecations from vertx4-SNAPSHOT to vertx 4 milestone-X. Vertx4snapshot is not available in maven. Although we are currently fine at vertx 3.8.4

lukehutch commented 4 years ago

Thanks for the heads up. I haven't tried compiling with Vertx 4 yet. As far as I know, Vertx 4 is still very far from locking down the API. There have been many breaking changes, and there will be many more. Therefore it does not make sense to port code to Vertx 4 yet.

runnermann commented 4 years ago

Ok, agree that v 4 wont be ready for a while. FYI the POM has 4.0.0-SNAPSHOT. Also had problems compiling with the doc generator and the using sonatype.

I commented out those sections and it compiled with 0 errors.

Also have a question on what the SocketHandler is used for. Is that for internal generation using HTML templates?

From: Luke Hutchison notifications@github.com Sent: Sunday, December 1, 2019 9:55:09 AM To: lukehutch/serverx serverx@noreply.github.com Cc: Lowell Stadelman lowell.stadelman@gmail.com; Author author@noreply.github.com Subject: Re: [lukehutch/serverx] Compile issues w/ deprications in Vertx 4milestoneX (#2)

Thanks for the heads up. I haven't tried compiling with Vertx 4 yet. As far as I know, Vertx 4 is still very far from locking down the API. There have been many breaking changes, and there will be many more. Therefore it does not make sense to port code to Vertx 4 yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/lukehutch/serverx/issues/2?email_source=notifications&email_token=AGC7W75C3GNLMIL3UTOMBP3QWP273A5CNFSM4JTMXPT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFRQGYA#issuecomment-560137056, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGC7W75ZKECLCTFU2FPPPYDQWP273ANCNFSM4JTMXPTQ.

lukehutch commented 4 years ago

OK, I probably built the last version before 4.0.0 and 3.8.4 had diverged in API.

What were the issues with the doc generator and distributionManagement?

SocketHandler was intended for SockJS support. I never ended up testing this, and it is possible that it's not currently working. I notice in the docs I mentioned that to use SockJS, you should use Handler<SockJSSocket>, not SocketHandler, so I think this was a work in progress, and honestly it has been a long time since I looked at the code. If you need WebSockets / SockJS support, feel free to get this working, and submit patches.

runnermann commented 4 years ago

We currently do not need SockJS support for this version, but may in the future.

I looked at the doc generator for the docs.The tag on line 333 was throwing an error.

-html5 I modified it to "html5" and it compiled with a couple warnings. Javadoc Warnings > javadoc: warning - No source files for package html5 > C:\Users\Me\IdeaProjects\appache\serverx\src\main\java\serverx\utils\ReflectionUtils.java:6: > error: cannot find symbol > import java.lang.reflect.InaccessibleObjectException; > ^ > symbol: class InaccessibleObjectException > location: package java.lang.reflect > javadoc: warning - No source files for package html5 > I was also able to uncomment distributionManagement. There are still some issues but I believe they are with the way they are imported into the project. On Mon, Dec 2, 2019 at 1:54 AM Luke Hutchison wrote: > OK, I probably built the last version before 4.0.0 and 3.8.4 had diverged > in API. > > What were the issues with the doc generator and distributionManagement? > > SocketHandler was intended for SockJS support. I never ended up testing > this, and it is possible that it's not currently working. I notice in the > docs I mentioned that to use SockJS, you should use Handler, > not SocketHandler, so I think this was a work in progress, and honestly > it has been a long time since I looked at the code. If you need WebSockets > / SockJS support, feel free to get this working, and submit patches. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > , > or unsubscribe > > . >
lukehutch commented 4 years ago

I looked at the doc generator for the docs.The tag on line 333 was throwing an error. <javadoc.html.version>-html5</javadoc.html.version>

That means you're building in JDK 8 or earlier. That switch is only supported in JDK 9+.