search

lukeiwanski / tensorflow

OpenCL support for TensorFlow via SYCL
Apache License 2.0
65 stars 14 forks source link

[SYCL] Registered Ops to use TF_CALL_SYCL_NUMBER_TYPES #207

Closed lukeiwanski closed 6 years ago

lukeiwanski commented 6 years ago

This PR introduces TF_CALL_SYCL_NUMBER_TYPES.

During configuration process user is able to specify which datatypes to support (eg. double, half) as they are extensions in OpenCL and support on various platforms may not be guaranteed.

Rbiessy commented 6 years ago

Looks good to me, it is much cleaner!

Rbiessy commented 6 years ago

Why the need to revert changes for conv_ops?

lukeiwanski commented 6 years ago

Yes, double implementation is causing few tests to segfault

jwlawson commented 6 years ago

Looks good to me. We'll need to look into the double convolution failures separately.