search

lukejacksonn / perflink

Low friction JavaScript benchmarks that you can share via URL
https://perf.link
1.21k stars 43 forks source link

Color linking / indicators #7

Closed atomiks closed 4 years ago

atomiks commented 5 years ago

Great work @lukejacksonn!

Currently, it's not too difficult to match up the test case with each result, but maybe consider using some color indicators to link them together? The difference between the vertical stacking of the test cases and horizontal stacking of the result bars is slightly confusing to me.

Also, maybe highlight the fastest piece of code?

lukejacksonn commented 5 years ago

Thanks for checking it out 🙇

I love your idea.. but haven't had time to think of an appropriate colour scheme yet. The results were numbered at some point but I removed that. I do agree it needs to be more clear.

Perhaps, preliminarily some reaction to hovering over the test cases could highlight the result in blue or something, and the fastest output could be coloured green?

I will have to think on it a bit more, let me know your thoughts!

atomiks commented 5 years ago

Perhaps, preliminarily some reaction to hovering over the test cases could highlight the result in blue or something, and the fastest output could be coloured green?

I think this is perfect, if you hover over the test case it'll highlight the matching result

lukejacksonn commented 5 years ago

Awesome, that will be a quick win. I will try get this implemented asap. Thanks again!

lukejacksonn commented 4 years ago

Hey @atomiks 👋 I just merged #24 where the test cases and bars on the graph are now numbered. Not having this was certainly confusing. I didn't got for colours in the end due to all the accessibility foot guns.

Hope this helps and sorry it took so long to implement 🙇