search

lukejacksonn / react-slack-clone

Complete chat application, built with Chatkit | by @lukejacksonn
https://pusher.com/chatkit
MIT License
1.35k stars 260 forks source link

Initial attempt to add notification support. #52

Closed DevFlex closed 6 years ago

DevFlex commented 6 years ago

There is still and issue that when you refresh it shows all of the notifications again. It also needs some touch up work around the requesting user permission flow for the notifications.

I just thought I would create a pull request early so you can provide feedback if need be.

lukejacksonn commented 6 years ago

Hey @DevFlex upon first scan, this looks great! One thing I would note is that, it is hard to tell exactly what has changed when there are so many whitespace changes. This is my fault for not adding a prettier config/task to the repo and adding it to the contribution guidelines.

Do you use prettier?

lukejacksonn commented 6 years ago

Thanks for this @DevFlex I have included your commit in here #54 and merged.. now we have Desktop Notification support 🎉 if you feel like picking another issue to tackle, go ahead!

DevFlex commented 6 years ago

hey @lukejacksonn thanks for the feedback on that I will have to checkout what else you added in there. I will pick up another issue. I have just checked out prettier and it looks pretty cool haven't used it before, but if there is any specific config overrides you want me to use just let me know, or maybe I should just add it to the repo as well?

lukejacksonn commented 6 years ago

Yeh they should be added to the repo really, the only non-default option I would insist on for this project is semicolons false. I have prettier installed on my editor with these settings, but we should add an npm script for it too; so people can run it before making a pull request. I will add it to my list of things to do!

bookercodes commented 6 years ago

@DevFlex Amazing work on this, thanks so much. Would love to send you a Pusher T-shirt and some stickers from the team to say "thanks".

Could you please email me your address and T-shirt size. I'm booker@pusher.com.