search

lukejacksonn / react-slack-clone

Complete chat application, built with Chatkit | by @lukejacksonn
https://pusher.com/chatkit
MIT License
1.35k stars 262 forks source link

Prevent empty space messages #71

Closed yazeedb closed 5 years ago

yazeedb commented 5 years ago

Hi,

It seems users can send empty spaces as messages.

To better align with Slack and other messaging clients, would a PR patching this be helpful?

screen shot 2018-11-30 at 7 49 34 am

screen shot 2018-11-30 at 7 51 01 am

lukejacksonn commented 5 years ago

As far as the Chatkit API is concerned.. this is a valid message

yazeedb commented 5 years ago

True. But should this app's UX conform to an API spec, or the app being modeled after, Slack?

Just found empty space messages jarring as a user, reminds me of Microsoft Lync 😨

0xr00tf3rr3t commented 5 years ago

Some input validation should fix this. Might give it a try later

On Sat, Dec 1, 2018, 14:37 Yazeed Bzadough <notifications@github.com wrote:

True. But should this app's UX conform to an API spec, or the app being modeled after, Slack?

Just found empty space messages jarring as a user, reminds me of Microsoft Lync 😨

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pusher/react-slack-clone/issues/71#issuecomment-443448037, or mute the thread https://github.com/notifications/unsubscribe-auth/AFcK8ZgmkLV5DQwtnJ_6aigKW3gwwJDCks5u0sx6gaJpZM4Y7niU .

lukejacksonn commented 5 years ago

Yes, this should not be too much work to add. @yazeedb makes a good point about the UX. WOuld be happy to look at a PR for it!