search

lukejacksonn / react-slack-clone

Complete chat application, built with Chatkit | by @lukejacksonn
https://pusher.com/chatkit
MIT License
1.35k stars 260 forks source link

Don't send empty space messages #73

Closed yazeedb closed 5 years ago

yazeedb commented 5 years ago

Addresses issue https://github.com/pusher/react-slack-clone/issues/71

  1. Trim the user's input (cut out leading/trailing whitespace)
  2. Bail if input is empty
  3. Otherwise, continue existing logic

Thoughts @mike1136? Wondering if you imagined a similar implementation.

0xr00tf3rr3t commented 5 years ago

Looks pretty straightforward for what I had in mind

lukejacksonn commented 5 years ago

Yup. LGTM 👍

hamchapman commented 5 years ago

Thanks!