search

lukejpreston / junit_viewer

Start a mini service to view junit reports
39 stars 17 forks source link

Feature request: allow it to run within a browser #26

Closed gwynjudd closed 8 years ago

gwynjudd commented 8 years ago

I want to allow a user to (say) paste in XML from a test run and render it in browser instead of in node. For my purposes, there are two parts to this:

  1. allow it to be built in browserify by making some code tweaks so that the readFileSync calls in render.js can be resolved at build time by brfs
  2. add a renderXML method that be called with text content of XML to be rendered instead of a file name

I have a PR almost ready to submit for this.

lukejpreston commented 8 years ago

so this makes it that junit_viewer can be called in the browser?

Can you create some sort of sample thing #27 in the README or a separate file as part of the gh-pages to show this in action?

gwynjudd commented 8 years ago

@lukejpreston I've added a sample in the readme in #27. Is it enough? I haven't edited any .md files before so please let me know if there are any formatting tips or mistakes I made/could do better.

lukejpreston commented 8 years ago

appologies I thought I had merged this, but apparently merge conflict, once you update your branch I will merge and do an update

gwynjudd commented 8 years ago

@lukejpreston I think the conflict should be fixed now