lukeme / gobible

Automatically exported from code.google.com/p/gobible
1 stars 0 forks source link

Go Bible Creator optional command switch -u #101

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
According to the Go Bible Creator page, there are two optional parameters:

-d
    Specifies a source text directory where all Source-Text urls will be
relative to. See below for more details on the Source-Text property in the
Collections.txt file.

-u
    Update option: Using this option GoBibleCreator will update existing
JAR files if they exist rather than create new ones. The source text will
not be parsed nor will new Bible Data be generated however everything else
we be updated including the GoBibleCore, book names, UI properties, JAD
file, manifest, etc. This option is useful if the source text hasn't
changed and there hasn't been any change to the Go Bible Data Format as it
will be much quicker to process each collection.

I just tried using the -u switch for the first time ever.

The earlier JAD file gets overwritten by the updated one (as expected).
The earlier JAR file gets renamed with file extension .JAR.TMP
The updated JAR file was not the same size as the earlier one!

No changes were made to either the collections text file or the source text
file, so there must be something different about how the update option
works.  I don't yet understand these results.

Please review the source code.

Does the update option use the same gobiblecore2.jar ?

Original issue reported on code.google.com by DFH...@gmail.com on 19 Jan 2010 at 10:39

GoogleCodeExporter commented 8 years ago
Observations for Kyrgyz2008 Go Bible.

Earlier JAR file 1,764,267 bytes (the one with file extension .JAR.TMP)
Updated JAR file 1,760,203 bytes
Size difference      4,064 bytes

The class files etc, all had the same sizes and CRCs.

Original comment by DFH...@gmail.com on 19 Jan 2010 at 10:49

GoogleCodeExporter commented 8 years ago
Perhaps the act of expanding and compressing the Bible Data for the JAR file (a 
form
of compressed ZIP file) is more efficient for the update option?

Original comment by DFH...@gmail.com on 19 Jan 2010 at 10:56

GoogleCodeExporter commented 8 years ago
IMHO, we should decide whether it makes any sense to retain the earlier file 
with
extension .TMP after a successful rebuild using the update option.

This file should be retained only if the update rebuild fails because of some 
other
cause, such as an error in either the collections file or source text file. If 
it is
retained, then it should be reverted to its original name without the .TMP 
extension.

btw. I have yet to try the update option from scratch, after first removing the 
JAD &
JAR files. 

Original comment by DFH...@gmail.com on 19 Jan 2010 at 11:02

GoogleCodeExporter commented 8 years ago
Maybe the source code should be examined!

If you run the update option from scratch, only the JAD file is created.
There is no output to standard error.  Errorlevel is not set.

Standard output contained:

----------------------------------
GoBibleCreator Version: 2.4.0
----------------------------------
D:\Download\Java\GoBibleCreator\GoBibleCreator\GoBibleCreator.240\GoBibleCore\ui
.properties
 exists:True
Writing Collection Kyrgyz2008: 
Error: existing JAR file does not exist:
D:\Download\Java\GoBibleCreator\GoBibleCreator\Work\Kyrgyz\Kyrgyz2008.jar
An existing JAR file must exist when the -u option is used.

Original comment by DFH...@gmail.com on 19 Jan 2010 at 11:07

GoogleCodeExporter commented 8 years ago

Original comment by DFH...@gmail.com on 19 Jan 2010 at 11:17

GoogleCodeExporter commented 8 years ago
Any progress on this issue?

Original comment by DFH...@gmail.com on 12 Aug 2012 at 4:03

GoogleCodeExporter commented 8 years ago

Original comment by DFH...@gmail.com on 3 Jan 2013 at 4:57