search

lukeme / gobible

Automatically exported from code.google.com/p/gobible
1 stars 0 forks source link

Add optional line to the Collections File - "Empty-Verse-Text:" #112

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
When this line is present, the text following the label will be used when 
an empty verse is found in the Creator parsing of the data. 

EX: 
Empty-Verse-Text: [...]

Would put "[...]" as the verse text for verses that were empty.

This is an addon feature that is being stuck in on the tail of Issue 91 
that is going into 2.4.0.

Original issue reported on code.google.com by dhinton...@gmail.com on 1 Apr 2010 at 4:15

GoogleCodeExporter commented 8 years ago 
Part of the pre-release version of Creator dated 4/1 11:16 AM.

Original comment by dhinton...@gmail.com on 1 Apr 2010 at 4:19

GoogleCodeExporter commented 8 years ago 
Does it conflict at all with the solution to issue 28?

http://code.google.com/p/gobible/issues/detail?id=28

Had you thought of that possibility?

Original comment by DFH...@gmail.com on 1 Apr 2010 at 4:26

GoogleCodeExporter commented 8 years ago 
For verifying the solution, use the WEB and examine Luke 17:36 and/or Acts 
15:34.

Action: DFHMCH

Original comment by DFH...@gmail.com on 1 Apr 2010 at 4:39

GoogleCodeExporter commented 8 years ago 
Yes it's been coded to work with issue 28 (that's why it took an extra hour); 
but 
it's always good to run it through some independent tests (read as: 
non-developer 
tests).

As always, please test changes thoroughly.  :-)

Original comment by dhinton...@gmail.com on 1 Apr 2010 at 4:51

GoogleCodeExporter commented 8 years ago 
I tried building the WEB, with this line added to the WEB.txt file

Empty-Verse-Text: [#####]

I then opened the JAR file using 7-Zip, extracted file "42_Luke.ptx 3" and 
searched
for "There will be two grinding grain together", which is part of Luke 17:35.

See attached PNG file.

Luke 17:35 is followed immediately by the contents of Luke 17:37, "They, 
answering,
asked him, “Where, Lord?” He said to them, "

I therefore conclude that the solution is not working. 

Moreover the empty verse has been treated as if it were a missing verse.

Original comment by DFH...@gmail.com on 1 Apr 2010 at 7:12

Attachments:

GoogleCodeExporter commented 8 years ago 
The last sentence in my previous comment is incorrect:

When I installed it into my phone, verse 36 is present, but appears empty.

This does not alter the fact that the solution has not worked.

I attach the java.log file from build time.

Original comment by DFH...@gmail.com on 1 Apr 2010 at 7:31

Attachments:

GoogleCodeExporter commented 8 years ago 
I have emailed you all the files needed to try the same test yourself, Dan.

Original comment by DFH...@gmail.com on 1 Apr 2010 at 7:32

GoogleCodeExporter commented 8 years ago 
Corrections have been made: 
- the Empty-Verse-Text: item wasn't being read before the file was processed
- the verse was getting replaced but then lost again

Both are working now. This should be fixed.

Original comment by dhinton...@gmail.com on 1 Apr 2010 at 9:53

GoogleCodeExporter commented 8 years ago 
Solution verified with the WEB. 

The Empty Verse Text appeared in 5 places:

Luke 17:36
Acts 8:37
Acts 15:34
Acts 24:7
Romans 16:25

FIO.  I attach a list of individual NT verses that are sometimes omitted by some
modern Bible translations. The verse list can be opened in Bible Desktop, the 
!JSword
based application from !CrossWire. 

This list excludes the disputed ending of Mark 16 and the pericope adulterae in 
John 8.

Original comment by DFH...@gmail.com on 2 Apr 2010 at 10:25

Attachments: