Using the update option does not replace the icon

[GoogleCodeExporter]

I just used the GoBibleCreator update "-u" option on a Bible.

The collections file now includes the line

Phone-Icon-Filepath: book_logo.png

The current directory path does contain the above PNG file.

However, the existing PNG file was NOT replaced!

This is a software defect - one that requires fixing for v2.4.0
even though this is a new issue.

Original issue reported on code.google.com by DFH...@gmail.com on 6 Apr 2010 at 1:57

[GoogleCodeExporter]

The urgency is because I do not have possession of the source text file[s], so 
the
only method I can use is the update option.

Original comment by DFH...@gmail.com on 6 Apr 2010 at 1:59

[GoogleCodeExporter]

Original comment by DFH...@gmail.com on 6 Apr 2010 at 1:59

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by DFH...@gmail.com on 6 Apr 2010 at 3:09

[GoogleCodeExporter]

Original comment by dhinton...@gmail.com on 9 Apr 2010 at 9:50

• Changed state: Started

[GoogleCodeExporter]

Please double check this issue. 

When I've tested it, the icon name remains "Icon.png" but the contents of the 
icon 
is now the same as the passed in icon. So, the name may not be changed, but the 
actual icon has.

Original comment by dhinton...@gmail.com on 9 Apr 2010 at 10:20

• Changed state: Invalid

[GoogleCodeExporter]

I examined the extracted Icon.png file before I reported the issue.
It was the original cross icon, not the required book icon.

I will try again.

When you did your test, was the source text file present or absent?
Could this make a difference to program flow?

Original comment by DFH...@gmail.com on 10 Apr 2010 at 7:38

[GoogleCodeExporter]

I have just tried again. This issue has not been fixed. It is still a valid 
issue.

I used update option with part of the KJV for which I do have the source text.

The internal file Icon.png remained as the cross icon, even though the 
collections
file has the following line.

Phone-Icon-Filepath: .\book_logo.png

or merely

Phone-Icon-Filepath: book_logo.png

The above PNG file is present in the same directory.

Original comment by DFH...@gmail.com on 10 Apr 2010 at 12:45

• Changed state: Accepted

Attachments:

• book_logo.png

[GoogleCodeExporter]

Just to confirm that using GoBibleCreator normally (without the "-u") does 
cause the
internal file Icon.png to be changed to the book icon.

Original comment by DFH...@gmail.com on 10 Apr 2010 at 12:51

[GoogleCodeExporter]

I am still unable to make this fail. 

I'm running it in the debugger in a recent project folder. The arguments are: 
"-u 
Collections.txt".

The icon contents are always being updated by the icon specified in the 
Collections.txt file - even though it's still called Icon.png in the created 
Jar.

Maybe zip up the whole project folder and tell me the command line arguments 
you are 
running and I'll try to duplicate it here. Unfortunatly it's working for me ... 
:-)

Original comment by dhinton...@gmail.com on 12 Apr 2010 at 3:27

• Changed state: Started

[GoogleCodeExporter]

See also http://code.google.com/p/gobible/issues/detail?id=76

Original comment by DFH...@gmail.com on 12 Apr 2010 at 7:06

[GoogleCodeExporter]

I've now run this from the command line with out running the debugger and still 
am 
able to use the -u option to update the contents of the Icon.png in the 
resultant 
jar. 

At this point I will need a zipped up directory tree where you are executing 
this 
and having a problem. Please include the argument name of the file that you are 
passing with the -u option. I am unable to make this code not work as expected. 
If 
you still have a problem, please post the requested zip with your changed 
status of 
this issue. Thanks.

Original comment by dhinton...@gmail.com on 12 Apr 2010 at 8:01

• Changed state: Fixed

[GoogleCodeExporter]

Make works. Update doesn't know where the icon is!  How strange is that?

See attached java.log

The error.log was empty.

Tip: Enhance the standard output from GBC to indicate (up front, as we say) 
whether
Update option "-u" is used.  Likewise if the "-d" option is used, record that 
too.

Original comment by DFH...@gmail.com on 13 Apr 2010 at 9:13

• Changed state: Accepted

Attachments:

• java.log

[GoogleCodeExporter]

Added output to the log file when the -u and -d options have been added. The -u 
options produces the following output:
 ** The "Update-only"(-u) flag has been found: updating the JAR/JAD files.

The -d option produces the following output:
 ** The "Directory"(-d) flag has been found.
 ** Using <C:\Internet\Downloads\GoBible> as the base Source Directory.

Original comment by dhinton...@gmail.com on 13 Apr 2010 at 2:52

• Changed state: Fixed

[GoogleCodeExporter]

For the "-u" option, could you include a second line, please.

 ** The original JAR file[s] are renamed with file extension .TMP

Original comment by DFH...@gmail.com on 13 Apr 2010 at 3:02

[GoogleCodeExporter]

Error: Icon file doesn't exist<book_logo.png>.

Needs a space adding after the word "exist"

Original comment by DFH...@gmail.com on 13 Apr 2010 at 3:04

[GoogleCodeExporter]

Comment 14 and 15 requests added to the code.

Original comment by dhinton...@gmail.com on 13 Apr 2010 at 3:08

[GoogleCodeExporter]

Recent comments changes validated.  Still investigating & discussing the main 
issue.

Original comment by DFH...@gmail.com on 13 Apr 2010 at 3:14

[GoogleCodeExporter]

Updated the file GBC_2.4_Readme.txt to record the recent changes.

Original comment by DFH...@gmail.com on 13 Apr 2010 at 7:31

[GoogleCodeExporter]

It was demonstrated that there was a real software defect.

Dan has fixed the main issue. DFHMCH has verified the code fix. 

These lines just added to the file GBC_2.4_Readme.txt

 BUG FIX:
  - Using the option-only switch -u now correctly finds the Phone-Icon-Filepath.
    This uses a path relative to the location of the collection text file.

Original comment by DFH...@gmail.com on 14 Apr 2010 at 4:52

• Changed state: Verified