Empty-Verse-Text: property did not work for ThML source text in GoBibleCreator 2.4.0

[GoogleCodeExporter]

Two chapters of my ThML file have empty verses.

The collections file contains the following line.

Empty-Verse-Text: missing from source text - awaiting a corrected file

The above property did not work for ThML source text format

The ThML file is illustrated in the attached PNG file.
Hebrews 5:1-14 has proper tags but no text (not even a space character).

Reported for a Go Bible JAR file made with GoBibleCreator 2.4.0

I suspect the enhancement for the new property was coded only for USFM
source format, but not for ThML or OSIS.

Original issue reported on code.google.com by DFH...@gmail.com on 22 Apr 2010 at 8:14

Attachments:

• Hebrews5_EmptyVerses1to14(ThML).png

[GoogleCodeExporter]

If the new property (as added first in v2.4.0) has been coded only for USFM, 
then the
interim workaround is to document the fact by an edit to the file Go Bible 
Creator
2.4 readme.txt

This can be done quickly, as soon as Dan gives me the facts.

Original comment by DFH...@gmail.com on 23 Apr 2010 at 6:58

[GoogleCodeExporter]

A look into the code shows that in Thml, the first action taken on a verse is 
to 
replace all the new line characters with spaces. 

This is a problem now with the "Empty Verse" concept as a space is not 
considered 
empty, so the verse that could only contain a space is not considered empty and 
isn't getting the replacement value of the "Empty-Verse-Text:" contents.

This is a logic problem and can be fixed.

The logic for applying the "Empty-Verse-Text:" string is the same for all three 
data 
types: the verse has to be empty. So I would expect it to be working in USFM 
and 
OSIS .. but then I thought it was working in Thml too (I guess I didn't test 
it) ... :-(

[Another case for having some tests as part of this project. Unforturnatly I 
have 
not the time to do that at this time, but it would be a good task for another 
developer to undertake. Should be a new high priority issue.]

Original comment by dhinton...@gmail.com on 23 Apr 2010 at 2:47

[GoogleCodeExporter]

Original comment by DFH...@gmail.com on 24 Apr 2010 at 12:23

• Changed state: Accepted