search

lukeme / gobible

Automatically exported from code.google.com/p/gobible
1 stars 0 forks source link

Go Bible Creator does not take account of the USFM tags for tables #141

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
The following SFM tags are not processed by Go Bible Creator 2.4.0

Table markers:

\tr \td \tc 

etc.

Should be addressed before next software release.

Original issue reported on code.google.com by DFH...@gmail.com on 15 Dec 2010 at 11:06

GoogleCodeExporter commented 8 years ago 
This issue was encountered and reported by a helper for the Nepal Bible Society.

Original comment by DFH...@gmail.com on 15 Dec 2010 at 11:07

GoogleCodeExporter commented 8 years ago 
Just did a regular expression search for any markers with \\t  
Nepal Bible Society text uses these markers for table data:

\tr        Table row start – this is at the start of every row. e.g.

\tr \tc1  text  \tc2 text  \tcr3 text

\th1   \th2   \th3              Column headings – format \th#
\tc1   \tc2   \tc3              Column data – format \tc#
\tcr2  \tcr3                    Right aligned column – format \tcr#

The one below was not in the text but is another table marker:

\thr#                           Table heading right aligned

Original comment by DFH...@gmail.com on 15 Dec 2010 at 12:45

GoogleCodeExporter commented 8 years ago 
Cc: geodirk

Original comment by DFH...@gmail.com on 15 Dec 2010 at 2:58

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
What might be a reasonable implementation of tables? Real tables, or tables 
that downgrade nicely into text?

Original comment by daniel.s...@gmail.com on 15 Dec 2010 at 4:14

GoogleCodeExporter commented 8 years ago 
I haven't yet seen the examples from NBS. They are very protective of the 
source text.
I'm trying to assist as a third party "working in the dark", except for having 
access to the collections text files for use with GoBibleCreator.

I can only guess that the tables are for things like all those lists of various 
kinds in the book of Numbers, etc. Whether they'd degrade smoothly into text is 
impossible to tell without seeing the typeset PDFs. They might need spaces 
inserting in between adjacent columns in each row. 

How to process table headers is a mystery, as I don't know if the header text 
is canonical or not.

Original comment by DFH...@gmail.com on 15 Dec 2010 at 4:54

GoogleCodeExporter commented 8 years ago 
Pasted from an email sent by geodirk....

To do the look that they are after would require code changes to the importer 
and GoBible's core code itself.  While there could be many approaches to doing 
something like this, probably the simplest way would be to have it look 
something like this where you put in the return and then add in some periods or 
dashes:

"And this was the number of coins:
Gold
...300
Silver
...500
Bronze
...800."

If you do it this way, you eliminate the need to have to keep track of screen 
resolution sizes, font issues, etc.  I'm sure that this approach is probably 
not the ideal one that a bible society would prefer since they seem to be 
looking for something like this according to what you sent:

"And this was the number of coins:
Gold....................300
Silver...................500
Bronze................800"

But you will run into lots of problems with this if you have long words in the 
first column and a narrow screen:

Gold....................300
Silver...................500
Bronze................800
Platinum Based S600
ynthetic Resin

But, like I mentioned above, to even do the first, simplistic version, it would 
require a change to the GoBibleCore.

Original comment by DFH...@gmail.com on 16 Dec 2010 at 4:32

GoogleCodeExporter commented 8 years ago 
The above comments don't even begin to tackle the possibility of tables having 
more than two columns.

Original comment by DFH...@gmail.com on 17 Dec 2010 at 9:39

GoogleCodeExporter commented 8 years ago 
Actually, by using the same method for subsequent cells, the data can still be 
represented fairly unambiguously.

Gold
...500
...£3.00
Silver
...200
...£1.00

Original comment by daniel.s...@gmail.com on 18 Dec 2010 at 11:55

GoogleCodeExporter commented 8 years ago 
The method described in comment 9 has been implemented in the Symscroll branch. 
For testing, please.

Original comment by daniel.s...@gmail.com on 19 Jan 2011 at 2:20

GoogleCodeExporter commented 8 years ago 
Does the implementation method automatically adjust to the width of the display 
screen?

i.e. For phones with a wide screen, no need to split the table row.

If so, does the code look ahead to see which is the "worst case" row in the 
current table?

Original comment by DFH...@gmail.com on 19 Jan 2011 at 2:43

GoogleCodeExporter commented 8 years ago 
It is implemented purely in GoBibleCreator using the worst-case method.

"And this was the number of coins:
Gold
...300
Silver
...500
Bronze
...800."

Original comment by daniel.s...@gmail.com on 19 Jan 2011 at 3:50

GoogleCodeExporter commented 8 years ago 
If we were to include these table tags in USFMSettings.txt (for Go Bible 
Creator 2.4.5) what should we do with them?

Original comment by DFH...@gmail.com on 31 Dec 2012 at 2:17

GoogleCodeExporter commented 8 years ago 
Currently difficult with GoBibleCore 2.4.x, because 2.4.x doesn't support line 
breaks in the middle of verses. Better to use SymScroll.

Original comment by daniel.s...@gmail.com on 31 Dec 2012 at 2:26

GoogleCodeExporter commented 8 years ago

Original comment by DFH...@gmail.com on 3 Jan 2013 at 10:34