search

lukeme / gobible

Automatically exported from code.google.com/p/gobible
1 stars 0 forks source link

Please handle \wj_...\wj* in SFM #168

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Include "/wj" in sfm file
2. gobile shows "j"
3. gobile removes "/w" so "/wj" shows as "j"
4. please handle "/wj"

What is the expected output? What do you see instead?
Show output with "j" from "/wj"

What version of the product are you using? On what operating system?
GoBibleCreator 2.4.3 Notes 
August 26, 2012

Please provide any additional information below.

Original issue reported on code.google.com by mcasan...@gmail.com on 12 Dec 2012 at 7:14

Attachments:

GoogleCodeExporter commented 8 years ago 
\wj_...\wj* did work earlier.

The code for handling \w_...\w* was inserted more recently.

Clearly it must have been added too early in the source code!

This was an oversight when we added the enhancement to cover
 \w_...\w*, \wg_...\wg* and \wh_...\wh*

If the programmer is available, I'll ask him to make a new build to fix this.
It could take some time, as he is currently travelling back to the Far East.

Original comment by DFH...@gmail.com on 12 Dec 2012 at 3:28

GoogleCodeExporter commented 8 years ago 
The other causal aspect to this issue is that the processing of the tag pair 
\w_...\w* was seriously mis-coded.

Rather than removing "\w", it should have removed "\w " and "\w*".
Had this been done, the bug would not have occurred.

Original comment by DFH...@gmail.com on 13 Dec 2012 at 12:05

GoogleCodeExporter commented 8 years ago 
For the record: Email received today.

Dear David,

I have checked in the fix into trunk. Binaries are attached.

I am not sure ignoring the \w not followed by spaces is a solution, as it could 
have implications on other source texts. Try it and see?

Daniel

Original comment by DFH...@gmail.com on 14 Dec 2012 at 9:14

GoogleCodeExporter commented 8 years ago 
The USFM reference manual clearly defines the syntax. The underline in the tag 
definitions represents a space.

If there are any source texts which omit the space in the tag pair \w_...\w*
then they would be a deviation from the defined syntax.

However, I'm informed that a new line in Paratext is treated syntactically the 
same as a space, so one always has to be careful when parsing USFM files.

Original comment by DFH...@gmail.com on 14 Dec 2012 at 9:19

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Go Bible Creator binary update is version 2.4.4

Original comment by DFH...@gmail.com on 14 Dec 2012 at 9:30

GoogleCodeExporter commented 8 years ago 
Updating documentation as follows: (file GBC_2.4_Readme.txt)

GoBibleCreator 2.4.4 Notes 

December 14, 2012

GoBibleCreator updated as follows.
 BUG FIX: (Issue 168 - see below)
  - Processing of tag pair \w_...\w* corrected 
    to prevent interference with tag pairs \wg_...\wg*, \wh_...\wh*, \wj_...\wj*
 BUG FIX: (Issues 165,167 - see below)
  - Merged patch to fix processing of the file separator in Unix style OS

Original comment by DFH...@gmail.com on 14 Dec 2012 at 9:41

GoogleCodeExporter commented 8 years ago 
Now that I'm in contact with the issue reporter, having asked him to test the 
fix, I have uploaded the package to the downloads.

Original comment by DFH...@gmail.com on 14 Dec 2012 at 12:49

GoogleCodeExporter commented 8 years ago 
The issue reporter has replied:

I downloaded, GoBibleCreator 2.4.4 version in
http://code.google.com/p/gobible/downloads/list

It is handled \wj_...\wj* in SFM.

Thank you!

Original comment by DFH...@gmail.com on 14 Dec 2012 at 2:02