lukeme / gobible

Automatically exported from code.google.com/p/gobible
1 stars 0 forks source link

The last character in a book is not found by a search #75

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Search the KJV for "Amen." (without the quotes)
2. Best to restrict the search scope to the NT.
3. There are 19 results.

What is the expected output? What do you see instead?

The results omit "end of book" verses such as Galatians 6:18, which ends
with "Amen."

4. Now search again for "Amen" (this time omitting the full-stop)
5. This time there are over 53 results, and these include Galatians 6:18

Thus the final "." in a book is not found by the Search feature.

It is not dependent on the character actually being a full-stop.

This bug was actually discovered in another translation in which 2
Corinthians 13:14 had "[...]" as the verse text (in place of an empty
verse).  Searching for "]" did not find this verse.

This seems to be another "Off By One" error.

Original issue reported on code.google.com by DFH...@gmail.com on 7 Oct 2009 at 11:04

GoogleCodeExporter commented 8 years ago
This one should be relatively simple to fix, and it would be sensible to 
consolidate
the fix along with that for issue 71.

Original comment by DFH...@gmail.com on 11 Nov 2009 at 8:09

GoogleCodeExporter commented 8 years ago
This one has been fixed and is in the current 'pending' pool to check in.

Original comment by dhinton...@gmail.com on 19 Nov 2009 at 10:22

GoogleCodeExporter commented 8 years ago

Original comment by DFH...@gmail.com on 20 Nov 2009 at 6:39

GoogleCodeExporter commented 8 years ago
Is this a correct description of the fix?

 - Search no longer fails to find the search term in the last chapter of a book.

Original comment by DFH...@gmail.com on 8 Dec 2009 at 4:20

GoogleCodeExporter commented 8 years ago
I would probably say:
- Search no longer fails to find a match that includes the last charater of a 
chapter.

(I don't remember if it was only a problem for the last chapter of a book or 
all 
chapters.)

Original comment by dhinton...@gmail.com on 8 Dec 2009 at 10:22