search

lukemelas / deep-spectral-segmentation

[CVPR 2022] Deep Spectral Methods: A Surprisingly Strong Baseline for Unsupervised Semantic Segmentation and Localization
227 stars 41 forks source link

Twice conversion to float for `image_lr` #17

Closed fuersta closed 1 year ago

fuersta commented 1 year ago

Hi, in https://github.com/lukemelas/deep-spectral-segmentation/blob/main/extract/extract.py#L204 and https://github.com/lukemelas/deep-spectral-segmentation/blob/main/extract/extract.py#L208 https://github.com/lukemelas/deep-spectral-segmentation/blob/main/extract/extract.py#L210 you convert image_lr to float by dividing through 255. Looks like a bug to me.

lukemelas commented 1 year ago

True, thanks for catching that! Fixed.

Luke