search

lukemonahan / missile_map

Missile Map Splunk visualisation
MIT License
3 stars 2 forks source link

New baselayers and speed variable #1

Closed A-McDougall closed 1 year ago

A-McDougall commented 6 years ago
lukemonahan commented 6 years ago

Thanks, I've been on holidays. I'll assess this in the coming days.

lukemonahan commented 6 years ago

Hi: Did you modify src/missile_map.js and then build visualization.js using the procedures here:

http://docs.splunk.com/Documentation/SplunkCloud/6.6.3/AdvancedDev/CustomVizTutorial#Rebuild_the_visualization

It looks like you've modified visualization.js directly, which will be overwritten when the "npm run build" occurs. Either that or you missed missile_map.js in your commit?

A-McDougall commented 6 years ago

Ah. I didn't know that is how the visualization.js was built, so I had made all the changes directly to the visualization.js

Thanks for the link to the proper way to do it, I'll take a look and fix my branch at some point. I should also update the readme too.

Cheers, Alistair

On 8 January 2018 at 05:02, lukemonahan notifications@github.com wrote:

Hi: Did you modify src/missile_map.js and then build visualization.js using the procedures here:

http://docs.splunk.com/Documentation/SplunkCloud/6.6.3/AdvancedDev/ CustomVizTutorial#Rebuild_the_visualization

It looks like you've modified visualization.js directly, which will be overwritten when the "npm run build" occurs. Either that or you missed missile_map.js in your commit?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lukemonahan/missile_map/pull/1#issuecomment-355884821, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNvU5TOV3V_cOvn16Y5EqFJX5_OSCs5ks5tIaFhgaJpZM4Q_MsV .