search

lukemorales / query-key-factory

A library for creating typesafe standardized query keys, useful for cache management in @tanstack/query
https://www.npmjs.com/package/@lukemorales/query-key-factory
MIT License
1.16k stars 32 forks source link

chore: upgrade tanstack version to 5 #82

Closed Gabswim closed 7 months ago

changeset-bot[bot] commented 9 months ago

⚠️ No Changeset found

Latest commit: 2b0bc9e970166737390ba50d92b6f3abd985d032

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lukemorales commented 9 months ago

Hi @Gabswim, thanks for your contribution.

A few things:

  1. We cannot simply bump the react query version because a lot of people still are on v4, and with the breaking changes that V5 brings, it will take some time for folks, especially in a big codebase, to migrate over. So we should accept both versions.
  2. Could you explain your changes in the prepare script?
lukemorales commented 7 months ago

Upgrade to tanstack v5 will come in a major version currently in the works