search

lukemorton / lily

A lightweight web application library for PHP 5.3+.
https://github.com/DrPheltRight/lily
MIT License
10 stars 0 forks source link

Add HHVM support #4

Open lukemorton opened 10 years ago

lukemorton commented 10 years ago

Builds currently failing for HHVM. Need to look into why, look's like syntax issues.

Don't have to definitely support HHVM but knowing why we can or can't would be good.

lukemorton commented 10 years ago

Managed to fix most if the errors with this tidy up 2c0118a95e06de97882d488839b6ab0d3588495d. However we still have one failing error message:

There was 1 error:

1) Lily\Test\Adapter\HTTPTest::testResponseBodySent
PHPUnit_Framework_Exception: HipHop Fatal error: Uncaught exception 'PHPUnit_Framework_Error_Warning' with message 'No such file or directory' in /home/travis/build/DrPheltRight/lily/vendor/phpunit/php-code-coverage/src/CodeCoverage.php:678
Stack trace:
#0 (): PHPUnit_Util_ErrorHandler::handleError()
#1 /home/travis/build/DrPheltRight/lily/vendor/phpunit/php-code-coverage/src/CodeCoverage.php(678): file()
#2 /home/travis/build/DrPheltRight/lily/vendor/phpunit/php-code-coverage/src/CodeCoverage.php(569): PHP_CodeCoverage->getLinesToBeIgnored()
#3 /home/travis/build/DrPheltRight/lily/vendor/phpunit/php-code-coverage/src/CodeCoverage.php(321): PHP_CodeCoverage->applyIgnoredLinesFilter()
#4 /home/travis/build/DrPheltRight/lily/vendor/phpunit/php-code-coverage/src/CodeCoverage.php(293): PHP_CodeCoverage->append()
#5 /home/travis/build/DrPheltRight/lily/vendor/phpunit/phpunit/src/Framework/TestResult.php(728): PHP_CodeCoverage->stop()
#6 /home/travis/build/DrPheltRight/lily/vendor/phpunit/phpunit/src/Framework/TestCase.php(754): PHPUnit_Framework_TestResult->run()
#7 /tmp/php-wrap-bNAhS0(89): PHPUnit_Framework_TestCase->run()
#8 /tmp/php-wrap-bNAhS0(321): __phpunit_run_isolated_test()
#9 {main}

See travis for more information on the test results: https://travis-ci.org/DrPheltRight/lily

Ideas anyone?

fordnox commented 10 years ago

I also have the same issue https://travis-ci.org/fordnox/php-dbunit-on-travis-ci/jobs/25515262

goetas commented 10 years ago

See here for a solution:

https://github.com/goetas/html5-php/commit/f902b05cc252721e5440f3437d0c5de3e0a8d789#diff-98c12a693941ae3c4f50872403416471R10

lukemorton commented 10 years ago

Awesome I'll try this later. Thank you. On 17 Jun 2014 11:31, "Asmir Mustafic" notifications@github.com wrote:

See here for a solution:

goetas/html5-php@f902b05#diff-98c12a693941ae3c4f50872403416471R10 https://github.com/goetas/html5-php/commit/f902b05cc252721e5440f3437d0c5de3e0a8d789#diff-98c12a693941ae3c4f50872403416471R10

— Reply to this email directly or view it on GitHub https://github.com/DrPheltRight/lily/issues/4#issuecomment-46290847.