lukeorth / poison

Professional Hugo theme for dev bloggers. Based on Mdo's classic Hyde theme.
https://poison.lukeorth.com
GNU General Public License v3.0
199 stars 98 forks source link

og_image seems to need to be in both 'assets' and 'static' #131

Closed rawwerks closed 10 months ago

rawwerks commented 11 months ago

if i put my og_image file only in assets/images, the og:image meta tag is written, but the image file gives a 404 error.

if i put my og_image file only in static/images, the og:image meta tag is NOT written, but the direct file path exists.

in order for the og_image to work, i need to have the same file in both assets/images and static/images, which seems fishy to me.

i checked the demo site, which doesn't use og_image, but does have the brand_image in both folders:

image

is this really necessary to have the same file in two places? i have never noticed this dependency with other hugo themes...but maybe i wasn't paying close attention.

rawwerks commented 11 months ago

these might offer a clue, context on the different ways files need to be called, depending on whether they are in /static or /assets

rawwerks commented 11 months ago

see #133 for potential fix