lukeorth / poison

Professional Hugo theme for dev bloggers. Based on Mdo's classic Hyde theme.
https://poison.lukeorth.com
GNU General Public License v3.0
198 stars 98 forks source link

Tags in dark mode have low contrast #91

Closed delroth closed 1 year ago

delroth commented 1 year ago

Screenshot from the demo website: out

This is below the recommended contrast for website text and is flagged (correctly, imo) as an accessibility issue. In general the colors there are defined weirdly in my opinion:

In light mode this works ok because --list-color uses a dark foreground color (as expected from light mode), and white has good contrast with that. But in dark mode this ends up with white on grey instead.

I don't have a strong preference on how to fix this, personally on my website I've overridden the tags to use code background/foreground colors instead and I think it looks nice :p

lukeorth commented 1 year ago

I agree, this is an accessibility issue. Using the code background/foreground colors sounds like a good fix. I'll play around with it a bit and see what I can find. :slightly_smiling_face:

lukeorth commented 1 year ago

After playing around with it a bit, I've decided to update the tag text to use the --table-stripe-color CSS variable.

image

image