Null safety (NNBD) - Githubissues

lukepighetti / fluro

Fluro is a Flutter routing library that adds flexible routing options like wildcards, named parameters and clear route definitions.

https://pub.dev/packages/fluro

MIT License

3.67k stars 417 forks source link

Null safety (NNBD) #205

Closed lukepighetti closed 3 years ago

lukepighetti commented 3 years ago

We should probably migrate 1.x to non-nullable by default as a hotfix.

lukepighetti commented 3 years ago

1.x will be migrated to null safety before work on Nav 2.0 rewrite begins.

lukepighetti commented 3 years ago

Null-safe version is available as a git dependency here: https://github.com/lukepighetti/fluro/tree/null-safety

fluro:
  git: 
    url: https://github.com/lukepighetti/fluro
    ref: null-safety

lukepighetti commented 3 years ago

Related: https://github.com/dart-lang/sdk/issues/41398#issuecomment-770467724

lukepighetti commented 3 years ago

Quick note on stability and null-safety.

We have 1.7.8 on pub which does not have null safety. This is a stable package.
UPDATE We now have 2.0.2 on pub which is null safe. This is a stable package.

muhlba91 commented 3 years ago

@lukepighetti any timeline for 2.0 or would it be possible to release 1.x nnbd as a pre-release version as well in the meantime?

lukepighetti commented 3 years ago

Let me revisit this early this coming week. Is the git dep not going to work for you?

lukepighetti commented 3 years ago

The null safe version of Fluro is now available as 2.0.3 on pub. There are no changes except for null-safety. I'm not happy about burning this major release on null-safety, but it was the right thing to do. Perhaps Fluro 2 will now be Fluro 3. 😅