lukepighetti / mastodon_dart

Unofficial 🐘 client written in 🎯
https://pub.dev/packages/mastodon_dart
MIT License
28 stars 8 forks source link

Rename mastodon_dart to mastodon #70

Closed abraham closed 1 year ago

abraham commented 1 year ago

I randomly ran across https://github.com/mykdavies/Mastodon/issues/1. This updates the code so it can be published to https://pub.dev/packages/mastodon.

lukepighetti commented 1 year ago

Any thoughts on pros / cons on migrating the name at this point?

abraham commented 1 year ago

The main pro would probably be the "SEO". The "mastodon" package is the first result even though it has lower likes, points, and popularity. I personally like the cleaner imports but I'm vain like that 😆.

-import 'package:mastodon_dart/mastodon_dart.dart';
+import 'package:mastodon/mastodon.dart';

Con would be devs using mastodon_dart would have to migrate. Although it's basically a find and replace for package:mastodon_dart/mastodon_dart.

lukepighetti commented 1 year ago

I think my main concern is that if we use mastodon then I don't have full control over the package, I'm just added as an uploader. @GroovinChip care to weigh in?

GroovinChip commented 1 year ago

We named the package as we did because we were also maintaining a Flutter package. The naming distinguishes it as being a pure Dart package. I believe the name should remain as it is.

GroovinChip commented 1 year ago

Not to mention we are already the official mastodon Dart client. Says so in their docs ;)

abraham commented 1 year ago

The docs just link to the other package. https://docs.joinmastodon.org/client/libraries/#dart

We named the package as we did because we were also maintaining a Flutter package.

That suggests to me that it's no longer a reason to use the _dart name.

abraham commented 1 year ago

I really don't care one way or the other. I saw that issue and thought changing the name would be better long term for the project.

GroovinChip commented 1 year ago

@lukepighetti ball's in your court

lukepighetti commented 1 year ago

We used to be on their website, I wonder if we were removed when I deprecated this package (before opening it up post Twitter acquisition). We should be on their list regardless of the name of the package

lukepighetti commented 1 year ago

I opened a PR to fix the official docs https://github.com/mastodon/documentation/pull/1164 so that it's at least correct

I don't feel comfortable closing this ticket yet until there is consensus

GroovinChip commented 1 year ago

IMO even though mastodon_flutter is deprecated at the moment, keeping the naming as-is is beneficial in that it A) Distinguishes this package as a Dart from others that may be Flutter packages B) Keeps the distinction in case we decide in the future to reverse the deprecation of mastodon_flutter

lukepighetti commented 1 year ago

@Abraham I'm going to close this, reasons:

1) I don't like the idea of someone who isn't actively developing the package having full control over the pub entry 2) mastodon team is usually pretty good at merging website changes like https://github.com/mastodon/documentation/pull/1164 3) migration awareness concerns