`alignment` support - Githubissues

lukepighetti / salomon_bottom_bar

Yet another bottom navigation bar, but with a few key promises.

https://pub.dev/packages/salomon_bottom_bar

MIT License

258 stars 55 forks source link

`alignment` support #35

Closed patelpathik closed 1 year ago

patelpathik commented 2 years ago

Problem

While working on a project with salomon_bottom_bar package, I had to change the alignment of the elements. I made ad-hoc changes locally.

Solution

Let the user pass the mainAxisAlignment.
- The given value will affect only if the length > 2
- If not given, the default value will affect, i.e. spaceBetween
Though I'm not sure if it comes under the planned features of the package, I submit a PR.

lukepighetti commented 2 years ago

Hi. Thank you for the PR. Promise 3 is that we will mimic BottomNavigationBar semantics. I do not see an alignment property on it. Can you please tell me if you have the same issue with BNB and how you use the existing BNB API to solve it? If we can get that answered, we can determine if there is a code change to be made here. Thank you.