search

lukepighetti / salomon_bottom_bar

Yet another bottom navigation bar, but with a few key promises.
https://pub.dev/packages/salomon_bottom_bar
MIT License
258 stars 55 forks source link

✨ Added feature to enable developers specify a background color. #37

Closed georonathan47 closed 1 year ago

georonathan47 commented 1 year ago

Developers can now add the preferred backgroundColor of their choice by calling the backgroundColor option...

lukepighetti commented 1 year ago

3 questions

georonathan47 commented 1 year ago

To answer your questions 1: Yes, that's essentially what I did (Wrapping the entire widget around a Container)

  1. For this question, I'll need to understand what you mean by minimal diff
  2. Yes.
lukepighetti commented 1 year ago

If backgroundColor is null, The navigation bar's background color defaults to the Material background color, ThemeData.canvasColor (essentially opaque white)

BottomNavigationBar – Flutter API Docs

Let's copy this functionality, use a ColoredBox, and make this a minimal diff.

A minimal diff is the the absolute minimum code changes needed to add the feature.

georonathan47 commented 1 year ago

Sure... I will close this PR and open a new one with the minimal diff using ColoredBox

On Sun, Dec 18, 2022 at 5:58 PM Luke Pighetti @.***> wrote:

If backgroundColor https://api.flutter.dev/flutter/material/material/BottomNavigationBar/backgroundColor.html is null, The navigation bar's background color defaults to the Material https://api.flutter.dev/flutter/material/material/Material-class.html background color, ThemeData.canvasColor https://api.flutter.dev/flutter/material/material/ThemeData/canvasColor.html (essentially opaque white)

Let's copy this functionality, use a ColoredBox, and make this a minimal diff.

A minimal diff is the the absolute minimum code changes needed to add the feature.

— Reply to this email directly, view it on GitHub https://github.com/lukepighetti/salomon_bottom_bar/pull/37#issuecomment-1356845392, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANRVGIXDP7KD7YZCZ7OCU63WN5GFTANCNFSM6AAAAAATCBHGCU . You are receiving this because you authored the thread.Message ID: @.***>

lukepighetti commented 1 year ago

Sounds good, thanks!