Migration published && migrating error

Cannonb4ll commented 8 years ago

I was kind of suprised I got a migration from this package, then I realized it was actually a very good idea to save the cart to the user, I was bound to use it but I ran into some weird errors.

Is there a reason you are giving the migration the year 2000 so it comes first in line? The default laravel user migration is from 2014-10-12 so if you try to add columns to that table, errors occur:

Nothing to rollback. [Illuminate\Database\QueryException] SQLSTATE[42S02]: Base table or view not found: 1146 Table 'voormeubels.users' doesn't exist (SQL: alter table users add cart_session_id varchar(255) not null) [PDOException] SQLSTATE[42S02]: Base table or view not found: 1146 Table 'voormeubels.users' doesn't exist
Each time we do php artisan vendor:publish --provider='LukePOLO\LaraCart\LaraCartServiceProvider' it would publish/overwrite the migration, which is kinda weird.

Is it OK if I make a PR for this?

Cannonb4ll commented 8 years ago

See PR #120

lukepolo commented 8 years ago

Hey glad you did that PR, merged in, will publish soon. I just did some more upgrades and want to make sure everything is sound before making a release for it. Now for the first issue No there i not a reason for year 2000 , I forget why I did that. Ill go ahead and change that

Cannonb4ll commented 8 years ago

Awesome mate, this PR fixes both the issues I describe by the way :)

I'll be looking forward to your release & upgrade.

lukepolo commented 8 years ago

Oh oups thank you very much!

lukepolo commented 8 years ago

Released , should be stable.

lukepolo commented 8 years ago

Glad your using the cross device stuff I put in. Thought I was the only one!

Cannonb4ll commented 8 years ago

I am currently building a webshop for a customer of mine, and I had this package in the back of my mind :)

I will help wherever I can, also whenever I find bugs I will report them to you.

lukepolo / laracart

Migration published && migrating error #119