search

lukeraymonddowning / pest-plugin-larastrap

Wraps your Pest suite in a Laravel application instance, allowing global use of the framework in tests.
MIT License
9 stars 2 forks source link

Add Pest v2.0 support #3

Closed pedrogxv closed 1 year ago

pedrogxv commented 1 year ago

All the main things I did in this PR is contained inside CHANGELOG.md 'Unreleased' section.

What I've changed?

Notes

  1. The main goal of this PR was to update the Pest version used by the package.
  2. I could only have a sucessfully test run using Laravel 10... so the new requirement should probably specify this change.
  3. I noticed that the supported php versions is kinda odd, I was thinking in including the 8.2... but that's for another PR.
lukeraymonddowning commented 1 year ago

@pedrogxv thanks very much for the work here. Are you able to update the GitHub Actions file to remove the outdated checks?

pedrogxv commented 1 year ago

Sure, I will take a look.

Em ter., 28 de mar. de 2023 às 10:12, Luke Downing @.***> escreveu:

@pedrogxv https://github.com/pedrogxv thanks very much for the work here. Are you able to update the GitHub Actions file to remove the outdated checks?

— Reply to this email directly, view it on GitHub https://github.com/lukeraymonddowning/pest-plugin-larastrap/pull/3#issuecomment-1486864234, or unsubscribe https://github.com/notifications/unsubscribe-auth/APDQBULJCXNRDWNL7VPBL3LW6LPUPANCNFSM6AAAAAAWHD6M4Y . You are receiving this because you were mentioned.Message ID: @.***>

pedrogxv commented 1 year ago

The action still fires an error in the composer update command, I really could'nt understand it. I was also not able to recreate it locally, it runs normally.

image

I thought about running composer update --ignore-platform-reqs instead, but I dont know if it is a good idea.