Adding responsiveTextFieldPlaceholderColor modifier to update a ResponsiveTextField's placeholder color

lukeredpath / swift-responsive-textfield

A SwiftUI wrapper around UITextField with binding-based state and responder control

Apache License 2.0

85 stars 15 forks source link

Adding responsiveTextFieldPlaceholderColor modifier to update a ResponsiveTextField's placeholder color #18

Closed mergesort closed 3 months ago

mergesort commented 8 months ago

I don't think this failure is me, I think it's flaky CI.

lukeredpath commented 8 months ago

LGTM - do you think you might be able to add a snapshot test?

lukeredpath commented 8 months ago

I need to update CI to use the correct simulator version as I think Xcode has been updated.

mergesort commented 8 months ago

Added a test, but I've never used snapshot tests so let me know if that works!

lukeredpath commented 3 months ago

@mergesort I just tried to update this to bring in the latest main and I think it updated your main branch. Can you try and revert the package changes in this PR please and I can get it merged in.

mergesort commented 3 months ago

Done!

mergesort commented 3 months ago

@lukeredpath Just as a heads up, I don't think the CI failures are cause of the code I changed.