lukesUbuntu / virtualmin_blesta

Blesta Virtualmin Module allow clients to mange there virtualmin hosting in blesta
MIT License
15 stars 2 forks source link

PHP error when adding a new service #3

Closed julianmatz closed 8 years ago

julianmatz commented 8 years ago

When adding a new service in Blesta, I get the following error message:

Oh noes!

Trying to get property of non-object on line 228 in public_html/blesta/components/modules/virtualmin_blesta/virtualmin_blesta.php

lukesUbuntu commented 8 years ago

@julianmatz what version of blesta are you using?

julianmatz commented 8 years ago

Hey, Luke. It's the latest production release. 3.6.1, I think. $row = $this->getModuleRow() returns a NULL value when trying to add a new service. On 28 Feb 2016 19:45, "Luke Hardiman" notifications@github.com wrote:

@julianmatz https://github.com/julianmatz what version of blesta are you using?

— Reply to this email directly or view it on GitHub https://github.com/lukesUbuntu/virtualmin_blesta/issues/3#issuecomment-189932526 .

lukesUbuntu commented 8 years ago

im running an older version but ill upgrade. are you running virtualmin with a ssl cert?

julianmatz commented 8 years ago

The problem seems to be that when adding a pacakge, it takes a very long time to load the module options.

When selecting Virtualmin as the module, the page tries to load the module options from admin/packages/moduleoptions/

This seems to be timing out, and therefore, the module_row variable is empty when trying to add a new service, if the package is saved without module options.

It only appears to be happening with the Virtualmin module. The module options for the other modules are loading quickly. I only noticed this when I left the page open for a while and then looked at the console log in Firebug.

julianmatz commented 8 years ago

I'm using a self-signed certifcate on the Virtualmin server right now.

julianmatz commented 8 years ago

There's also a JavaScript error:

Error: TypeError: $(...).val(...) is null Source File: /app/views/admin/default/javascript/jquery-1.8.3.min.js line 2 > eval Line: 16

lukesUbuntu commented 8 years ago

okay ill upgrade my dev to the latest and check it out currently working fine on my prod environment on blesta 3.5.

lukesUbuntu commented 8 years ago

just upgraded, and confirmed cple of issue on fresh install with fresh virtualmin as well

lukesUbuntu commented 8 years ago

Should be resolved several small issues i never picked up. Has now connection checking so when you save your virtual-min it will test the connection and dump curl error log or response same for packages as well.

Will have to pull down.

lukesUbuntu commented 8 years ago

closing as 0a53d5e21919fa19e5471852e923bffb5174fc39 has fixed issues, confirmed with fresh blesta 3.6 & fresh virtualmin install.