search

lukesampson / pshazz

Give your powershell some pizazz.
The Unlicense
577 stars 40 forks source link

Add dircolors plugin #8

Closed xpando closed 10 years ago

xpando commented 10 years ago

Added theme-able dir/file coloring plugin. If you don't want it part of the core pshazz project is there a way to package and distribute as an external plugin?

lukesampson commented 10 years ago

Cool, I like the idea of having directory colors in Pshazz. But this is a lot of code, and I'm not sure if it's been battle-tested enough to go into the default theme.

Can you put this all into the one file, so merge new-commandwrapper.ps1 and dircolors.ps1? That way it'll be clearer that they belong together.

Also, can you create a new theme (maybe called xpando?) and add the dircolor plugin there rather than add it to the default theme?

I'm thinking it'll be easier to start a new pull request for this, rather than undo the changes in this one.

That way anyone can quickly use your theme by typing pshazz use xpando, or they can add dircolors to their own theme too.

xpando commented 10 years ago

Makes sense. I'll update and send another pull request.