search

lukesnowden / FSVS

Full Screen Vertical Scroll
https://www.lukesnowden.co.uk/full-screen-vertical-scroll/
723 stars 145 forks source link

Cannot click on image links on mobile #24

Closed pathetix closed 9 years ago

pathetix commented 9 years ago

If I have a image wrapped in a link, the link becomes unclickable.

Eg:

        <p>
            <a href="http://www.google.com">
                <img src="image.jpg">
            </a>
        </p>
lukesnowden commented 9 years ago

what device? fiddle link? The only mouseclick events are here: https://github.com/lukesnowden/FSVS/blob/master/js/fsvs.js#L175 which there is no cancelation of the event.

pathetix commented 9 years ago

https://jsfiddle.net/pathetix/4geo5L55/1/

Basically any browser on mobile. I forked your fiddle and added a normal link and one image link. On my side the image link is not clickable.

lukesnowden commented 9 years ago

the links work fine for me..

edit: nope, your right. Think I might know what it is. leave it with me mate

pathetix commented 9 years ago

Oh that's strange. It didn't work for me on mobile. Maybe this screencast helps? https://db.tt/zjCB0tb3

lukesnowden commented 9 years ago

^ see above :+1:

0kai commented 9 years ago

I had found the same issue, all my mobile phone can't click the image button. did you have any idea to this?

0kai commented 9 years ago

@pathetix @lukesnowden I had modify some codes to fixed this issue. Maybe it's not a good idea, just for your information.

https://github.com/lukesnowden/FSVS/pulls