search

lukesnowden / FSVS

Full Screen Vertical Scroll
https://www.lukesnowden.co.uk/full-screen-vertical-scroll/
722 stars 145 forks source link

Added capability to scroll during slide transition #3

Closed roganartu closed 9 years ago

roganartu commented 9 years ago

lukesnowden/FSVS#2

lukesnowden commented 9 years ago

dunno about this one... you tested on track pad (mac)? it's quite sporadic.

lukesnowden commented 9 years ago

if you change it to

if( ( ! scrolling || ( options.mouseWheelDelay && Date.now() > mouseWheelScrollStart + options.mouseWheelDelay ) ) && Math.abs( wheely ) > 5 ) {

and change the mouseWheelDelay option default to false, this would be more appealing.

lukesnowden commented 9 years ago

that would leave it as is by default and then if the developer wants to tweak this option to there own needs it would be better.

roganartu commented 9 years ago

Tested on Ubuntu with a mouse.

roganartu commented 9 years ago

That change sounds good. I'll do that later this afternoon when I get home

roganartu commented 9 years ago

Applied the suggested change and did some quick testing. Let me know if there's any issues.

lukesnowden commented 9 years ago

I can't see there being anything wrong with this. merged!