search

lukesnowden / FSVS

Full Screen Vertical Scroll
https://www.lukesnowden.co.uk/full-screen-vertical-scroll/
723 stars 145 forks source link

Arrow keys interfere with native form field behaviour #6

Closed warrenski closed 9 years ago

warrenski commented 9 years ago

The current version of the bindKeyArrows() event handler code interferes with the expected native browser behaviour of the up and down arrow keys in the context of a form field.

As an example, let's say you embed a country dropdown list (<select> element and multiple <option> elements) inside of an FSVS slide. When a user interacts with the form field by pressing either the up or down arrow keys to change the selected dropdown option, FSVS erroneous triggers the slideUp() or slideDown() function respectively. In this instance, I believe the event bubbles all the way up the DOM but should probably be intercepted so that it doesn't bubble any further than the <form> element.

lukesnowden commented 9 years ago

Will sort this after work, thanks for letting me know

lukesnowden commented 9 years ago

This should now be resolved