text: Exercise 2 - Githubissues

lukethehuman / code-review-tutorial

Code review tutorial exercises

MIT License

0 stars 0 forks source link

text: Exercise 2 #3

Open github-actions[bot] opened 7 months ago

github-actions[bot] commented 7 months ago

Text Exercise 2: Women's world cup

In an article about the Women's world cup there has been a mix up between football, soccer, and the NFL.

Take a look at the article world_cup.md

Are you familiar with the subject matter?
Can you review the article without being an expert on the subject?

Take a look at the pull request:

Does the pull request address the issue?
Is the solution overly complicated? Add a comment on what you think is unnecessary? What is a good way to phrase your comment, what is a bad way?
What would improve the pull request? Add your review: Approve or Request changes
For your own code, do you write for a global audience? Would Google's developer documentation style guide be helpful?