lukevella / rallly-selfhosted

Example docker configuration for running your own instance of Rallly
https://rallly.co
109 stars 14 forks source link

services.rallly.depends_on contains an invalid type #15

Closed suntrop closed 11 months ago

suntrop commented 11 months ago

I just cloned to git repo and added my config data. But I get this error:

me:/home/users/me/rallly-selfhosted# docker-compose up -d
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.rallly.depends_on contains an invalid type, it should be an array
version: "3"
services:
  rallly_db:
    image: postgres:14.2
    restart: always
    volumes:
      - db-data:/var/lib/postgresql/data
    environment:
      - POSTGRES_PASSWORD=postgres
      - POSTGRES_DB=db
    healthcheck:
      test: [ "CMD-SHELL", "pg_isready -U postgres" ]
      interval: 5s
      timeout: 5s
      retries: 5

  rallly:
    image: lukevella/rallly:latest
    restart: always
    depends_on:
      rallly_db:
        condition: service_healthy
    ports:
      - 3000:3000
    environment:
      - DATABASE_URL=postgres://postgres:postgres@rallly_db:5432/db
    env_file:
      - config.env

volumes:
  db-data:
    driver: local

Didn't change anything. Having Docker version 24.0.5, build 24.0.5-0ubuntu1~20.04.

lukevella commented 11 months ago

It seems to have worked in the past but maybe some update removed support for this syntax? The docs do show it being an array though so I've updated the spec to match. Thanks for raising.