search

lukevella / rallly

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.
https://rallly.co
GNU Affero General Public License v3.0
3.68k stars 350 forks source link

Valid email addresses are rejected #1343

Closed paulmenzel closed 2 months ago

paulmenzel commented 2 months ago

On rally.co participant in a survey and enter an email address containing / and ~ in the local part. Such an email is incorrectly rejected, for example a+rally.co~/@example.net.

chrhi commented 2 months ago

Thanks for pointing this out! It looks like the current validation might be stricter than necessary, as / and ~ can technically be valid characters in the local part of an email address according to the email standards (RFC 5321/5322).

It might be worth revisiting the email validation logic to accommodate these characters. This would allow users to input email addresses that are valid but currently rejected. Just wanted to bring this up in case the maintainers want to address it. Appreciate the great work on the project!

lukevella commented 2 months ago

We use zod for email validation and I believe I've found the reason for this issue here: https://github.com/colinhacks/zod/pull/2157

This is also the reason why it won't be fixed as I have no plans to implement and maintain my own email validation. So I apologize for not being able to use your favorite email address with Rallly 🙏