Closed lukevella closed 1 month ago
vercel[bot]
commented
1 month ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| app | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 17, 2024 7:32pm |
| landing | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 17, 2024 7:32pm |
coderabbitai[bot]
commented
1 month ago This pull request modifies the package.json file for the "rallly" project, transitioning several scripts to utilize pnpm instead of prisma and yarn. New scripts have been added, and existing commands have been simplified. The workspaces section has been removed, and dependencies have been updated, including the addition of @radix-ui/react-select and preview-email. The package manager has also been changed from yarn to pnpm. Additionally, the next.config.js file has been updated to enhance Webpack configuration and include a new plugin.
| File Path | Change Summary |
|---|---|
package.json |
Updated scripts to use pnpm; added new scripts; removed @prisma/client dependency; added @radix-ui/react-select and preview-email; updated various dependency versions. |
apps/web/next.config.js |
Added @rallly/emails to transpilePackages; updated Webpack function to include isServer; conditionally added PrismaPlugin. |
package.json file, particularly the updates to scripts and dependencies, relate to the modifications in the .env.development and .env.test files in this PR, which also involve database connection settings and environment variable adjustments.package.json in the main PR, including dependency changes and the removal of @prisma/client, are relevant to this PR, which focuses on upgrading the next package and other dependencies, indicating a broader context of dependency management.🐇 In the fields where rabbits play,
PNPM has come to stay!
With actions new and scripts so bright,
Dependencies dance in the morning light.
Hopping along in a workspace cheer,
Our code is tidy, the path is clear! 🌼
apps/web/package.json (4)
`15-18`: **Verify the impact of test script changes.** The `test:integration` script has been simplified, and the `test` script that combined unit and e2e tests has been removed. This change aligns with the migration to pnpm but may have implications: 1. The removal of `NODE_ENV=test` from `test:integration` might affect the test environment setup. 2. There's no longer a single command to run both unit and integration tests together. Please ensure these changes don't negatively impact your testing process. Consider: 1. Verifying if `NODE_ENV=test` is set elsewhere for integration tests. 2. Creating a new script that combines `test:unit` and `test:integration` if needed. Run the following script to check: ```shell #!/bin/bash # Description: Verify the changes in test scripts and their usage in CI/CD. # Test 1: Check if NODE_ENV is set elsewhere for integration tests rg --type yaml -i "NODE_ENV.*test.*playwright" # Test 2: Look for any scripts that might be running both unit and integration tests rg --type yaml -i "test:unit.*test:integration|test:integration.*test:unit" ``` This comment reinforces the concerns raised in a previous review about potential issues with test script changes. --- Line range hint `1-113`: **Summary: Approve package.json changes with verification steps.** The changes in this `package.json` file are well-aligned with the PR objective of migrating to pnpm and transitioning to a monorepo structure. Key points: 1. Scripts have been updated, with some simplifications and removals. 2. Dependencies and devDependencies have been updated to use workspace references where appropriate. 3. New packages have been added, and some versions have been updated. Overall, these changes appear to be appropriate and consistent. However, to ensure a smooth transition, please: 1. Verify that all scripts, especially test scripts, work as expected with the new setup. 2. Confirm that all dependencies resolve correctly and don't introduce conflicts. 3. Check that the development environment and build process work smoothly with the updated devDependencies. Once you've completed these verifications, this PR should be ready for merging. --- Line range hint `24-91`: **Approve dependency updates and additions.** The changes in the dependencies section align well with the migration to pnpm and the move to a monorepo structure. Notable changes include: 1. Updated @rallly/* dependencies to use workspace references (e.g., `workspace:*`). 2. Added new dependencies like `@radix-ui/react-select` and `preview-email`. 3. Updated versions for several packages (e.g., `lucide-react`, `next-auth`). These changes are consistent with monorepo best practices and likely introduce new features or fix issues. To ensure these changes don't introduce any conflicts or breaking changes, please: 1. Run `pnpm install` to verify that all dependencies resolve correctly. 2. Execute your test suite to check for any potential issues with the updated packages. You can use the following script to check for any potential conflicts: --- Line range hint `94-111`: **Approve devDependencies updates and additions.** The changes in the devDependencies section are consistent with the migration to pnpm and the monorepo structure. Key changes include: 1. Addition of new devDependencies like `@next/env` and `@types/js-cookie`. 2. Updated @rallly/* devDependencies to use workspace references. 3. Updated version of `vitest` to `^2.1.1`. These changes improve TypeScript support and may introduce new testing features or improvements. To ensure these changes don't introduce any issues in the development environment, please: 1. Verify that all development scripts (e.g., build, lint) work correctly with the updated devDependencies. 2. Check if the new version of vitest introduces any breaking changes that might affect your tests. You can use the following script to verify:
lukevella
commented
1 month ago Couldn't get docker image to work. Got an error saying the prisma engine is missing. I give up.
Summary by CodeRabbit
Release Notes
New Features
Dependencies
@radix-ui/react-selectandpreview-email, for enhanced functionality.Chores
@rallly/emailsto the transpiled packages in the Webpack configuration.