lukevella / rallly

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.
https://rallly.co
GNU Affero General Public License v3.0
3.48k stars 326 forks source link

Make UI usable by blind people #306

Open fantasai opened 2 years ago

fantasai commented 2 years ago

Describe the bug One of the participants uses a screen reader and found the poll too difficult to use.

Expected behavior Usable with a screenreader. :)

Steps to Reproduce OK, this isn't how to actually reproduce, but it should give you an idea:

  1. Replace all the the embedded SVG images with nothing.
  2. Load the page in Firefox, go to View > Page Style > No Style
  3. Try to use the page.

In general, if you replace all images with their alt text and show the page without CSS, it should be well-organized and readable. If it's not, it means you need to fix your markup. Yours... definitely needs fixing.

How to Improve

  1. Sorry to be throwing RTFM at you, but, you need to start by learning to use HTML tags like <p> and <table> and <h3> and <section> and <pre> to organize the information. Find a nice, basic introductory book or read the HTML4 spec or something. Definitely the main section of the poll should be using table markup. Here's a few relevant tutorials from MDN: structuring text, lists, page structure, tables.
  2. Replace the embedded SVG with externally-referenced SVG using <img> tags, and use alt attributes to either mark the image as decorative (alt="") or give the text that it represents (e.g. alt="If need be", alt="Total Available: ").

There might be other things to fix as well, but this should get you 90% of the way there.

fantasai commented 2 years ago

This section of the CSS Writing Modes spec has some fairly complex tables, btw, you could probably just steal the markup structure: https://www.w3.org/TR/css-writing-modes-4/#unicode-bidi

frivoal commented 7 months ago

This issue is the main reason why I keep looking for alternatives, and cannot wholeheartedly recommend Rally.

nesges commented 2 weeks ago

This is a major issue for me as well

hometoast commented 1 week ago

I have a limited set of tools to validate screen reader readiness. So this might be a 'dumb question'. For interactions with poll elements, if you tab and space to a poll option. Changing the title would trigger the reader to re-read the element? title="Monday, September 16, 2024. No Vote" user presses space. element's title changes. title="Monday, September 16, 2024. Going"