search

lukevella / rallly

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.
https://rallly.co
GNU Affero General Public License v3.0
3.64k stars 342 forks source link

Top panel dropdown lists autohide on mobile (Android, Firefox) #934

Open Dima793 opened 12 months ago

Dima793 commented 12 months ago

Description When on a poll webpage in mobile view, tapping any dropdown list/menu button from above the poll tiles (account, Live, Manage) makes them appear for a fraction of a second and then hide back. Some observations:

Reproduction steps

  1. Open Firefox browser on Android
  2. Open Rallly website
  3. Tap "Get started" button
  4. Tap account button (at the top right corner of the webpage)

Expected behavior Dropdown list/menu should be kept expanded until next user action.

Video https://github.com/lukevella/rallly/assets/17815003/cf0b3b02-f793-4de4-9662-69a0f346d66d

Smartphone:

lukevella commented 12 months ago

Hi @Dima793, do you get this behavior when using the dropdown menu here as well:

https://ui.shadcn.com/docs/components/dropdown-menu

Dima793 commented 12 months ago

No, I don't get same behavior there. However, it has other oddities: My browser is set up to hide URL bar when scrolling down. If I tap Style dropdown list button or Open button when URL bar is hidden, website makes the bar appear again. In that case Style dropdown list button has inconsistent behavior, sometimes same as the above, but sometimes it works properly. Also, when choosing from Style dropdown list, first tap only highlights an option and second tap is required to confirm it.

While on Rallly poll webpage the initially described issue is consistent, happens without hiding URL bar and doesn't make it appear when it's hidden.

ltguillaume commented 11 months ago

Can confirm on Mull (Firefox fork), with and without uBlock Origin.

Unfortunately, there are no relevant entries in the (remote) browser console.

sharky98 commented 9 months ago

I observed the same behavior, but the dropdown stay with a long press. However, this is not the typical expected behavior for mobile users.

Mobile Firefox 122.0.1 Pixel Pro 8 Android 14

I have also made a video, that I am trying to find how to attach here 😅

https://github.com/lukevella/rallly/assets/8150191/fe1a8bf5-2b75-47c8-87a0-4afe3b3b5360

https://github.com/lukevella/rallly/assets/8150191/71fbc579-d729-4477-92bb-df832ac918fd

nliautaud commented 6 months ago

Note that the issue is a lot more problematic in the dropdowns where the first entry is an action : the option is instantaneously clicked.

I just deleted two comments by clicking on their ... settings drop-down.

lukevella commented 5 months ago

I've not been able to reproduce this issue myself. Could anyone let me know if this is still happening?

Dima793 commented 5 months ago

Could anyone let me know if this is still happening?

Just checked — yes, it does still happen consistently. Firefox 126.0, Android 14, Asus Zenfone 10.

Dima793 commented 5 months ago

@lukevella it seems fixed for user dropdown and comment action menus, just as mentioned in #1099 (UPD: comment deletion is still an issue too). But the issue is still present for other menus like the ones for profile actions and Manage (see attached screenshot). Screenshot_20240518-074308_Firefox_1

Dima793 commented 5 months ago

UPD: I was wrong, the issue is still present for comment deletion too. Just tried to unfold some comment's menu and the comment was instantly deleted.

lukevella commented 5 months ago

@Dima793 thanks for checking. To be honest I'm not sure what is causing this. Seems to be a bug in Firefox Android because it works fine on iOS. If anyone has more information please let me know.

lukevella commented 5 months ago

Did a bit more digging and found this issue which seems to be related: https://github.com/radix-ui/primitives/issues/2565

Will try applying the suggested workaround.

lukevella commented 5 months ago

The fix should be live now.

nliautaud commented 5 months ago

Unfortunately the bug is still present. Note that this isn't happening with a long press.