search

lukevenediger / statsd-csharp-client

A simple c# client library for statsd and statsd.net
MIT License
47 stars 20 forks source link

StatsdClient can now be given a postfix to append to all logging messages #11

Closed jefftucker closed 4 years ago

jefftucker commented 9 years ago

Also fixed the unit tests.

The unit tests were completely broken due to the change to async everywhere so they are now fixed and Moq is mostly eliminated in favor of a simple stub object.

StatsdClient can now be given a postfix name which will be appended to every stat. If the Statsd Client object is given the prefix "some.prefix" and the postfix "hostname" then using client.LogGauge("mygauge", 1) will result in the gauge "some.prefix.myguage.hostname" being sent to statsd. The use case for this feature is based on how Krux does monitoring, see presentation here: https://puppetlabs.com/presentations/puppet-camp-london-2014-how-measure-everything-million-metrics-second-minimal

niemyjski commented 8 years ago

What's the status of this @jefftucker ? Can this be merged safely?

niemyjski commented 7 years ago

Can you please update your pr and let me know about the perf diff. Then I'll get this merged in.

niemyjski commented 6 years ago

Can you please update your pr (resolve conflicts) and let me know about the perf diff. Then I'll get this merged in.

niemyjski commented 6 years ago

@jefftucker Can you please update the conflicts and update tests accordingly.