search

lukevenediger / statsd-csharp-client

A simple c# client library for statsd and statsd.net
MIT License
47 stars 20 forks source link

"Set" value should allow string #14

Closed josheinhorn closed 6 years ago

josheinhorn commented 9 years ago

So it is not at all clear from Etsy's docs, but I have confirmed that the Etsy StatsD server works with string Set values (e.g. userIds.unique:josheinhorn|s). I've also seen other StatsD client implementations allow sending string values for the Set metric type.

This would be highly useful since it's a very common occurrence to need to count unique occurrences of text values in addition to numeric values. For instance, you might want to count unique users that have User IDs with combinations of letters and numbers (think GUID), or count unique IP addresses (which appear to be numeric, but are obviously not).

Would of course be happy to take on the PR for this unless someone objects.

niemyjski commented 8 years ago

Can you submit a pr for this?

niemyjski commented 6 years ago

Can you submit a pr for this?

josheinhorn commented 6 years ago

Hey @niemyjski -- sorry I never followed up with this back in 2016. I've actually been out of the C# game for well over 2 years now, so I'm probably not the best guy to do this anymore 😳

Would you like me to close this issue?