search

lukevenediger / statsd-csharp-client

A simple c# client library for statsd and statsd.net
MIT License
47 stars 20 forks source link

Conversion to NET Standard 2.0 #22

Closed ghost closed 6 years ago

ghost commented 6 years ago

Conversion of the StatsdClient library to .NET Standard 2.0 so that it can be reference for use by either .NET Framework (4.6.1) or .NET Core applications.

niemyjski commented 6 years ago

Thanks for the PR! Can you please try reviewing the other pr as well and hopefully we can get this out with more changes.

ghost commented 6 years ago

You are welcome.

I took a brief look at the other pr and these are my thoughts. a) It was done is 2015 and so was based off older revision of the master. b) I don't believe the unit tests, need to be refactored as they appear to be working. But maybe I am missing something that Jeff spotted.

Basically this means that the only class that needs/could to be merged in would be Statsd.cs. However there are a number of conflicts here that mean that this would need to be a manual merge.

In my opinion, it would be better for the author to start over with a clean version of the source.