lukevenediger / statsd-csharp-client

A simple c# client library for statsd and statsd.net
MIT License
47 stars 20 forks source link

Added Async interface for async await development #7

Closed amiryonatan closed 9 years ago

niemyjski commented 9 years ago

Can you please review these changes. I think it would make it a lot cleaner and would be a great pr :)

niemyjski commented 9 years ago

@amiryonatan Can you please ensure you have the latest downstream so I can automatically merge the latest code in and if possible make the requested changes.

amiryonatan commented 9 years ago

Hey,

I pulled the latest version, and fixed all the remarks mentioned above. I'm not sure why it says there are conflicts and I don't know how to see them.

Thanks

niemyjski commented 9 years ago

Thanks, when I have conflicts I use https://code.google.com/p/tortoisegit/ to resolve conflicts. It's a nice easy to use ui.

niemyjski commented 9 years ago

Your changes look good thanks! Is there any chance you can resolve the conflicts and then I'll merge this pull request.