Added support for UPD/TCP communication to graphite

lukevenediger / statsd.net

A high-performance stats collection service that feeds into Graphite and aimed at small- to large-scale windows environments.

MIT License

123 stars 25 forks source link

Added support for UPD/TCP communication to graphite #25

Closed ThomasVestergaard closed 9 years ago

ThomasVestergaard commented 10 years ago

Graphite communication is now configurable to be either tcp or udp. An attribute is added to the configuration tag that decides whether to use UDP og TCP when sending data to graphite.

Also includes a bug fix which adds a "\r\n" after each line sent to graphite in both UDP and TCP. The UDP part is untested though.

lukevenediger commented 10 years ago

Thanks for adding this Thomas! I appreciate your contribution. I've made a few notes on some parts of the code, most notably:

The "protocol" parameter needs to be optional and fall back to "UDP" to preserve existing configuration files
The TCP socket needs to take intermittent connection failures into account.

Lastly, please can you test this with a Graphite server listening on UDP? That'll make sure your UDP sender is rock solid.

Cheers, Luke

ThomasVestergaard commented 10 years ago

Hi Luke Thanks for getting back so quick. I'll iterate over this again later this week.

Cheers

lukevenediger commented 9 years ago

Statsd.net now supports output to Graphite using TCP or UDP via a new backend. I'm going to close this request.