search

lukevers / kittens

A scriptable IRC bot hub written in Go with Lua plugins
MIT License
83 stars 10 forks source link

Make web server port configurable #37

Closed zackkitzmiller closed 10 years ago

lukevers commented 10 years ago

Looks good from my phone. I'll take a look when I get home again and merge it in.

On Jul 6, 2014, at 1:33 PM, Zack Kitzmiller notifications@github.com wrote:

You can merge this Pull Request by running

git pull https://github.com/zackkitzmiller/kittens port-config Or view, comment on, or merge it at:

https://github.com/lukevers/kittens/pull/37

Commit Summary

Make web server port configurable File Changes

M config.go (7) M kittens.go (3) Patch Links:

https://github.com/lukevers/kittens/pull/37.patch https://github.com/lukevers/kittens/pull/37.diff — Reply to this email directly or view it on GitHub.

lukevers commented 10 years ago

After I merged this I realized there were a few problems. If there was no port given it tried to just use "" as the port. I also updated the example configuration file.

Then I realized instead of just having a "port" config option there should be two options. One for the interface it binds to and one for the port.

So now there is config.Port and config.Interface.

zackkitzmiller commented 10 years ago

Yup. You're definitely right here. Great catch. I'll be more thorough in the future.

On Sunday, July 6, 2014, Luke Evers notifications@github.com wrote:

After I merged this I realized there were a few problems. If there was no port given it tried to just use "" as the port. I also updated the example configuration file.

Then I realized instead of just having a "port" config option there should be two options. One for the interface it binds to and one for the port.

So now there is config.Port and config.Interface.

— Reply to this email directly or view it on GitHub https://github.com/lukevers/kittens/pull/37#issuecomment-48125115.