search

lukevp / ESC-POS-.NET

Efficient, Easy to Use Thermal Printing & POS (Windows/Linux/OSX, WiFi/BT/USB/Ethernet)
MIT License
503 stars 166 forks source link

Add support for Samba-based network printing #159

Closed nickcharlton closed 2 years ago

nickcharlton commented 2 years ago

This adds support for printing via Samba-shared printers, along with an additional option for the ConsoleTest example. Opening up BasePrinter's Flush method also allows for other extensions too.

This is @lukevp's prior work, fixed to allow it to apply cleanly.

https://github.com/lukevp/ESC-POS-.NET/commit/006bff2d63c21e13bc08b8ad9d6b88d008595ccc

Closes #47

dredgy commented 2 years ago

Tested on SEWOO SLK-TE212 to great success.

dredgy commented 2 years ago

Hey Nick, I need Samba support and rasterization. Looks like you have implemented these for your purposes? Do you have a fork repo for the version of this you use?

nickcharlton commented 2 years ago

I've got a branch called combined-contributions which I've been using: https://github.com/nickcharlton/ESC-POS-.NET/commits/combined-contributions

I've been using Paket to reference the branch, as Visual Studio/.NET CLI doesn't support doing that.

Hopefully obvious caveats should apply using that branch though! I might break things, or need to pull more into it but we're using it in our builds in the real-world and will be until it's merged upstream.

dredgy commented 2 years ago

Thanks Nick, I’ll fork it. Great work

From: Nick Charlton @.> Sent: Monday, July 4, 2022 9:02:52 PM To: lukevp/ESC-POS-.NET @.> Cc: dredgy @.>; Comment @.> Subject: Re: [lukevp/ESC-POS-.NET] Add support for Samba-based network printing (PR #159)

I've got a branch called combined-contributions which I've been using: https://github.com/nickcharlton/ESC-POS-.NET/commits/combined-contributions

I've been using Pakethttps://github.com/fsprojects/Paket to reference the branch, as Visual Studio/.NET CLI doesn't support doing that.

Hopefully obvious caveats should apply using that branch though! I might break things, or need to pull more into it but we're using it in our builds in the real-world and will be until it's merged upstream.

— Reply to this email directly, view it on GitHubhttps://github.com/lukevp/ESC-POS-.NET/pull/159#issuecomment-1173681250, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARHIIMO5B3SFDWD7MISSV4TVSLAFZANCNFSM5M3PMM7A. You are receiving this because you commented.Message ID: @.***>

lukevp commented 2 years ago

This is awesome @nickcharlton , thanks for the contribution! Any way you could update the readme with directions on samba printing as well?

nickcharlton commented 2 years ago

Absolutely, I'll open a PR for that soon!