search

lukevp / ESC-POS-.NET

Efficient, Easy to Use Thermal Printing & POS (Windows/Linux/OSX, WiFi/BT/USB/Ethernet)
MIT License
500 stars 161 forks source link

Fixing Barcode length validation updated for PDF417 and Code128 #259

Open igorocampos opened 5 months ago

igorocampos commented 5 months ago

Fixes #253

Based on below manuals, length cap was wrong for PDF417 and Code128

image

image

lukevp commented 5 months ago

@igorocampos I see the change to the other barcode variable length checks, but for the PDF one, is it really only necessary to change the length limit? the rest of the code already works correctly for longer strings? have you been able to test this on a printer?

igorocampos commented 5 months ago

@igorocampos I see the change to the other barcode variable length checks, but for the PDF one, is it really only necessary to change the length limit? the rest of the code already works correctly for longer strings? have you been able to test this on a printer?

Unfortunately, I haven't :(

But according to the manual, there's no actual limit other than what you mentioned in #253, so in theory it should work. But yeah, it would be nice to have it actually tested in a printer.