lukew3 / mathgenerator

A math problem generator, created for the purpose of giving self-studying students and teaching organizations the means to easily get access to high-quality, generated math problems to suit their needs.
https://lukew3.github.io/mathgenerator
MIT License
690 stars 178 forks source link

Fixed faulty multiplication test #351 #356

Closed HelloGit-ty closed 3 years ago

HelloGit-ty commented 3 years ago

Fixed the multiplication test issue. The error was in passing a maxRes parameter as an argument to the multiplication.func() call since multiplication.func only takes one argument i.e. maxMulti. Also within the hypothesis given() decorator function maxRes wasn't required as well so removed that too. Lastly we did not need to assume anything while testing the multiplication function as we do need to check if any one operand is greater than the other one while doing basic multiplication.