search

lukewaite / alfred-gitlab

A GitLab workflow for Alfred 3
Other
299 stars 42 forks source link

Opening a project with quick_open set to false fails on first time #13

Open GabLeRoux opened 5 years ago

GabLeRoux commented 5 years ago

After pressing enter for the first time, the alfred window closes instead of showing the next choices when quick_open settings is set to false like this: image

How to reproduce

(happens everytime on my side)

  1. Make sure quick_open is set to false (open alfred settings, search for gitlab workflow, and click on the settings button:

    image

  2. Quit alfred (from the macos top menu bar)

  3. Open alfred again

  4. Write gl SomeExistingProject

  5. Press enter

The alfred window closes and does nothing (bug)

Repeat from step 4 and it will show the choices correctly.

image

Workaround

For now, I just set the feature back to true so it opens the project directly.

Suggestion

An improvement on the UX could be to have the quick open available when holding a keyboard key such as Alt or CMD.

Versions

Logs

Doesn't seem to contain anything interesting for the issue tho

Starting debug for 'GitLab'

[2019-04-26 09:03:21][STDERR: input.scriptfilter] 09:03:21 workflow.py:2247 DEBUG    ---------- GitLab (1.6.0) ----------
09:03:21 workflow.py:1657 DEBUG    reading settings from /Users/gableroux/Library/Application Support/Alfred 3/Workflow Data/com.lukewaite.alfred-gitlab/settings.json
09:03:21 workflow.py:2531 DEBUG    update check not due
09:03:21 workflow.py:2650 DEBUG    got password : com.lukewaite.alfred-gitlab:gitlab_api_key
09:03:21 workflow.py:1884 DEBUG    loading cached data: /Users/gableroux/Library/Caches/com.runningwithcrayons.Alfred-3/Workflow Data/com.lukewaite.alfred-gitlab/projects.cpickle
09:03:21 workflow.py:1884 DEBUG    loading cached data: /Users/gableroux/Library/Caches/com.runningwithcrayons.Alfred-3/Workflow Data/com.lukewaite.alfred-gitlab/__workflow_update_status.cpickle
09:03:21 workflow.py:2461 DEBUG    update_data: {u'available': False}
09:03:21 workflow.py:2440 DEBUG    set last run version: 1.6.0
09:03:21 workflow.py:2289 DEBUG    ---------- finished in 0.069s ----------
[2019-04-26 09:03:22][STDERR: input.scriptfilter] 09:03:22 workflow.py:2247 DEBUG    ---------- GitLab (1.6.0) ----------
09:03:22 workflow.py:1657 DEBUG    reading settings from /Users/gableroux/Library/Application Support/Alfred 3/Workflow Data/com.lukewaite.alfred-gitlab/settings.json
09:03:22 workflow.py:2531 DEBUG    update check not due
09:03:22 workflow.py:2650 DEBUG    got password : com.lukewaite.alfred-gitlab:gitlab_api_key
09:03:22 workflow.py:1884 DEBUG    loading cached data: /Users/gableroux/Library/Caches/com.runningwithcrayons.Alfred-3/Workflow Data/com.lukewaite.alfred-gitlab/projects.cpickle
09:03:22 workflow.py:1884 DEBUG    loading cached data: /Users/gableroux/Library/Caches/com.runningwithcrayons.Alfred-3/Workflow Data/com.lukewaite.alfred-gitlab/__workflow_update_status.cpickle
09:03:22 workflow.py:2461 DEBUG    update_data: {u'available': False}
09:03:22 workflow.py:2440 DEBUG    set last run version: 1.6.0
09:03:22 workflow.py:2289 DEBUG    ---------- finished in 0.080s ----------
[2019-04-26 09:03:22][STDERR: input.scriptfilter] 09:03:22 workflow.py:2247 DEBUG    ---------- GitLab (1.6.0) ----------
09:03:22 workflow.py:1657 DEBUG    reading settings from /Users/gableroux/Library/Application Support/Alfred 3/Workflow Data/com.lukewaite.alfred-gitlab/settings.json
09:03:22 workflow.py:2531 DEBUG    update check not due
09:03:22 workflow.py:2650 DEBUG    got password : com.lukewaite.alfred-gitlab:gitlab_api_key
09:03:22 workflow.py:1884 DEBUG    loading cached data: /Users/gableroux/Library/Caches/com.runningwithcrayons.Alfred-3/Workflow Data/com.lukewaite.alfred-gitlab/projects.cpickle
09:03:22 workflow.py:1884 DEBUG    loading cached data: /Users/gableroux/Library/Caches/com.runningwithcrayons.Alfred-3/Workflow Data/com.lukewaite.alfred-gitlab/__workflow_update_status.cpickle
09:03:22 workflow.py:2461 DEBUG    update_data: {u'available': False}
09:03:22 workflow.py:2440 DEBUG    set last run version: 1.6.0
09:03:22 workflow.py:2289 DEBUG    ---------- finished in 0.067s ----------
Miaonster commented 2 years ago

I found a way to fix this.

  1. Double click the connector
image
  1. Check "Don't close the Application Window on actioning result" and Save
image
  1. Make sure quick_open is set to false, now you can see the choices after typing gl xxxx