search

lukeweber / webrtc-jingle-client

Webrtc audio + jingle protocol brought to IOS and Android.
https://groups.google.com/forum/?fromgroups#!forum/webrtc-jingle
BSD 3-Clause "New" or "Revised" License
335 stars 137 forks source link

Fix libsrtp #35

Closed dmonakhov closed 11 years ago

dmonakhov commented 11 years ago

libsrtp compiled with -DCPU_RISC doesn't work properly on android/arm. Visiable effect: AES's self-test failed during srtp_init() CPU_RISC is used for optimization only, and CPU_CISC should just work just fine, it has been tested on android/arm with srtp test applications and libjingle.

After srtp became usable it is safe to enable SDES by default.

bthemad commented 11 years ago

What procedure do you use to run the tests on the phone? I see the Unittest.mk for the android, but how do you actually run it?

dmonakhov commented 11 years ago

Just enable sdes security in voice-client-core/jni/tuenti/clientsignalingthread.cc like follows sp_mediaclient->set_secure(cricket::SEC_ENABLED); and found that client failed enable srtp, after some digging i've found that the answer.

bthemad commented 11 years ago

ok, I thought you somehow managed to run unit tests and found it. Thanks!