lukeweber
commented
11 years ago A bit more about specifics, we use TxmppSocket in xmppclient for our xmpp conneciton. When creating the thread, we may simple be able to pass macsocketserver to the thread() method in voiceclient.cc.
@https://developer.apple.com/library/mac/#documentation/NetworkingInternet/Conceptual/NetworkingTopics/Articles/UsingSocketsandSocketStreams.html "Note: POSIX networking does not activate the cellular radio on iOS. For this reason, the POSIX networking API is generally discouraged in iOS."
We can't use posix it seems, shit, looks pretty tangled, but maybe not.
It seems we should need to do something like this: http://stackoverflow.com/questions/12057151/voip-socket-on-ios-no-notifications-received
MacAsyncSocket uses CFSocket, which is a c bsd socket. I assume we would need to create a new socket, IOSAsyncSocket that uses the correct interfaces, but will have to confirm further. Otherwise if we can reuse MacAsyncSocket then we would have to reuse CFSocket with CFSocketNativeHandle CFSocketGetNative (CFSocketRef s) to plug into the code from the stackoverflow example above and use the read/write streams from the example. Don't think/am not sure that would work, as I think CFSocket is an underlying POSIX socket that won't work well on IOS.
Current code flow of using posix sockets: ............... Based on current thread get socket server and create a socket.
void TXmppSocket::CreateCricketSocket(int family) { talk_base::Thread* pth = talk_base::Thread::Current(); if (family == AF_UNSPEC) { family = AF_INET; } talk_base::AsyncSocket* socket = pth->socketserver()->CreateAsyncSocket(
............... Based on socket server that's passed in, construct message queue
libjingle/talk/base/thread.cc -> Thread::Thread(SocketServer* ss) : MessageQueue(ss), ...
....... if no socket server, create the default PhysicalSocketServer()
MessageQueue::MessageQueue(SocketServer* ss)
: ss(ss), fStop(false), fPeekKeep(false), active(false),
dmsgq_nextnum(0) {
if (!ss_) {
// Currently, MessageQueue holds a socket server, and is the base class for
// Thread. It seems like it makes more sense for Thread to hold the socket
// server, and provide it to the MessageQueue, since the Thread controls
// the I/O model, and MQ is agnostic to those details. Anyway, this causes
// messagequeue_unittest to depend on network libraries... yuck.
defaultss.reset(new PhysicalSocketServer());
ss_ = defaultss.get();
}
ss_->SetMessageQueue(this);
}
......
// Creates the underlying OS socket (same as the "socket" function). virtual bool Create(int family, int type) { Close(); s = ::socket(family, type, 0); udp = (SOCKDGRAM == type); UpdateLastError(); if (udp) enabledevents = DE_READ | DEWRITE; return s != INVALID_SOCKET; }
seankovacs
hailg
IOS recommends a few things for VoIP, specifically special sockets and timeout handlers.
http://developer.apple.com/library/ios/#documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/AdvancedAppTricks/AdvancedAppTricks.html#//apple_ref/doc/uid/TP40007072-CH7-SW12
There are several requirements for implementing a VoIP app:
Socket that would need to change to the IPhone recommended version is used here: ./third_party/libjingle/talk/xmpp/xmppengineimpl.cc
In terms of timeouts, we would need a handler that wakes up and calls the white space keepalive method located in clientsignalingthread.cc.